Replace the cubic_spline_interpolation macro with a generic function
#11605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanabenki
added
C-Code-Quality
alice-i-cecile
approved these changes
Jan 29, 2024
james7132
approved these changes
Jan 29, 2024
james7132
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
bevyengine#11605) # Objective - Address a `TODO` item in `bevy_animation`. ## Solution - Replace the `cubic_spline_interpolation` macro with a function. The function isn't marked as `#[inline(always)]` but from what I checked with `cargo asm` it gets inlined (even in debug, unless I explicitly add `#[inline(never)]`), so this should be identical to the macro. If needed I can add the attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TODOitem inbevy_animation.Solution
cubic_spline_interpolationmacro with a function.The function isn't marked as
#[inline(always)]but from what I checked withcargo asmit gets inlined (even in debug, unless I explicitly add#[inline(never)]), so this should be identical to the macro. If needed I can add the attribute.