Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call a TextureAtlasLayout a layout and not an atlas #11783

Merged
merged 2 commits into from Feb 13, 2024
Merged

Call a TextureAtlasLayout a layout and not an atlas #11783

merged 2 commits into from Feb 13, 2024

Conversation

NiklasEi
Copy link
Member

@NiklasEi NiklasEi commented Feb 8, 2024

Make the renamings/changes regarding texture atlases a bit less confusing by calling TextureAtlasLayout a layout, not a texture atlas.

@Kanabenki Kanabenki added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Feb 9, 2024
@CptPotato CptPotato mentioned this pull request Feb 12, 2024
Merged
@alice-i-cecile
Copy link
Member

@CptPotato I'd like your review here please :)

CptPotato
CptPotato approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@CptPotato CptPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. More consistent and clear terminology is always nice.

@CptPotato
Copy link
Contributor

CptPotato commented Feb 13, 2024 •
edited

On the topic of consistency, I noticed TextureAtlas::textures being also referred to as "sections", "areas" and "sprites" in different places. "Sections" seems to be the most used, though.

I think it's usually clear what is meant here. But maybe it's worth using a single term to refer to the textures in an atlas?

@NiklasEi NiklasEi added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 13, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@NiklasEi
Copy link
Member Author

It failed to save screenshots from running the WASM examples. Is that a common spurious failure?

@alice-i-cecile
Copy link
Member

I haven't seen it before 🤔 Lemme try again.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 13, 2024
Merged via the queue into bevyengine:main with commit aca71d0 Feb 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@CptPotato CptPotato CptPotato approved these changes

@doonv doonv doonv approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NiklasEi @alice-i-cecile @CptPotato @doonv @Kanabenki