Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Quad deprecation message mentioning a type that doesn't exist #11798

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix Quad deprecation message mentioning a type that doesn't exist #11798

merged 1 commit into from
Feb 9, 2024

Conversation

doonv
Copy link
Contributor

@doonv doonv commented Feb 9, 2024

Objective

The deprecation message of bevy::render::mesh::shape::Quad says that you should use bevy_math's Quad instead. But it doesn't exist.

Solution

Mention the correct primitive: Rectangle

@mockersf mockersf added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 9, 2024
@mockersf mockersf added this pull request to the merge queue Feb 9, 2024
Merged via the queue into bevyengine:main with commit f84672b Feb 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doonv @mockersf @pablo-lua