-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CameraProjection
panic and improve CameraProjectionPlugin
#11808
Conversation
This is now unblocked since #11766 has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks like a big improvement. Will approve later after I get the chance to evaluate this on examples.
@doonv I did a rebase and fixed conflicts: doonv#3 Notable conflicts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been running this in my own bevy fork for my game and it's been working well with my custom projection + pbr shadows. No complaints :)
…meraprojection-crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Well spotted to not need the check_visibility.after
given the recently added .before(CheckVisibility)
above.
Objective
Fix #11799 and improve
CameraProjectionPlugin
Solution
CameraProjectionPlugin
is now an all-in-one plugin for adding a customCameraProjection
. I also addedPbrProjectionPlugin
which is likeCameraProjectionPlugin
but for PBR.P.S. I'd like to get this merged after #11766.
Changelog
CameraProjectionPlugin
to be an all-in-one plugin for adding aCameraProjection
VisibilitySystems::{UpdateOrthographicFrusta, UpdatePerspectiveFrusta, UpdateProjectionFrusta}
, now replaced withVisibilitySystems::UpdateFrusta
PbrProjectionPlugin
for projection-specific PBR functionality.Migration Guide
VisibilitySystems
'sUpdateOrthographicFrusta
,UpdatePerspectiveFrusta
, andUpdateProjectionFrusta
variants were removed, they were replaced withVisibilitySystems::UpdateFrusta