Add meshing for ConicalFrustum
#11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Enhancement
NthTensor
approved these changes
Mar 4, 2024
lynn-lumen
approved these changes
May 25, 2024
There was a problem hiding this comment.
This looks good, but couldn't the cylinder mesh builder be replaced by this?
They seem to have the same builder methods and the conical frustum is just a generalisation of the cylinder. The types might be kind of confusing, but at least internally, they could share an implementation.
alice-i-cecile
approved these changes
May 25, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
ConicalFrustumprimitive should support meshing.Solution
Implement meshing for the
ConicalFrustumprimitive. The implementation is nearly identical toCylindermeshing, but supports two radii.The default conical frustum is equivalent to a cone with a height of 1 and a radius of 0.5, truncated at half-height.