Un-hardcode positions and colors in 2d_shapes example
#11867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
changed the title
2d_shapes example
rparrett
changed the title
2d_shapes example2d_shapes example
rparrett
added
C-Examples
alice-i-cecile
approved these changes
Feb 14, 2024
alice-i-cecile
added
the
A-Math
BD103
approved these changes
Feb 14, 2024
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Jondolf
approved these changes
Feb 14, 2024
Jondolf
added
the
S-Ready-For-Final-Review
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Jondolf
reviewed
Feb 14, 2024
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We recently got some neat new 2d shapes and the shapes are no longer centered on the screen.
The hardcoded positions and colors are a pain to deal with when a new shape is added.
Solution
Delete a bunch of code and position shapes evenly. Assign colors evenly too.
Before
After