Disable irradiance volumes on WebGL and WebGPU. #11909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They cause the number of texture bindings to overflow on those platforms. Ultimately, we shouldn't unconditionally disable them, but this fixes a crash blocking 0.13. Closes bevyengine#11885.
cart
approved these changes
Feb 16, 2024
IceSentry
reviewed
Feb 17, 2024
| @@ -825,7 +827,7 @@ impl SpecializedMeshPipeline for MeshPipeline { | |||
| shader_defs.push("ENVIRONMENT_MAP".into()); | |||
| } | |||
|
|
|||
| if key.contains(MeshPipelineKey::IRRADIANCE_VOLUME) { | |||
| if key.contains(MeshPipelineKey::IRRADIANCE_VOLUME) && IRRADIANCE_VOLUMES_ARE_USABLE { | |||
| shader_defs.push("IRRADIANCE_VOLUME".into()); | |||
There was a problem hiding this comment.
Why not just reuse this shader_def instead of using a separate one?
There was a problem hiding this comment.
I think there are two reasons:
- MeshPipelineKey::IRRADIANCE_VOLUME is currently getting set in scenes like
deferred_rendering.rs, even when irradiance volumes aren't used. - IRRADIANCE_VOLUMES_ARE_USABLE is used in a few places unconditionally outside of the context of shader defs.
There was a problem hiding this comment.
I think for now we merge as-is. This isn't hurting anything and we're likely to improve this situation in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They cause the number of texture bindings to overflow on those platforms. Ultimately, we shouldn't unconditionally disable them, but this fixes a crash blocking 0.13.
Closes #11885.