Skip to content

Make Globals visible in vertex shaders #12032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Feb 21, 2024
Merged

Make Globals visible in vertex shaders #12032

alice-i-cecile merged 1 commit into from
Feb 21, 2024

Conversation

@IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Feb 21, 2024 •
edited
Loading

Objective

  • Globals are supposed to be available in vertex shader but that was mistakenly removed in 0.13

Solution

  • Configure the visibility of the globals correctly

Fixes #12015

@IceSentry IceSentry added this to the 0.13.1 milestone Feb 21, 2024
@IceSentry IceSentry added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! labels Feb 21, 2024
@IceSentry IceSentry mentioned this pull request Feb 21, 2024
Closed
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 21, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 21, 2024
Merged via the queue into bevyengine:main with commit a513493 Feb 21, 2024
ameknite pushed a commit to ameknite/bevy that referenced this pull request Feb 22, 2024
@IceSentry @ameknite
Make Globals visible in vertex shaders (bevyengine#12032)
b054cd1 
# Objective

- Globals are supposed to be available in vertex shader but that was
mistakenly removed in 0.13

## Solution

- Configure the visibility of the globals correctly

Fixes bevyengine#12015
@IceSentry IceSentry deleted the globals-visibility branch February 22, 2024 18:59
@IceSentry IceSentry mentioned this pull request Feb 24, 2024
Open
@EmiOnGit EmiOnGit mentioned this pull request Feb 26, 2024
Merged
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@IceSentry @msvbg
Make Globals visible in vertex shaders (bevyengine#12032)
c81e9e4 
# Objective

- Globals are supposed to be available in vertex shader but that was
mistakenly removed in 0.13

## Solution

- Configure the visibility of the globals correctly

Fixes bevyengine#12015
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@IceSentry @msvbg
Make Globals visible in vertex shaders (bevyengine#12032)
7f0a620 
# Objective

- Globals are supposed to be available in vertex shader but that was
mistakenly removed in 0.13

## Solution

- Configure the visibility of the globals correctly

Fixes bevyengine#12015
mockersf pushed a commit that referenced this pull request Feb 27, 2024
@IceSentry @mockersf
Make Globals visible in vertex shaders (#12032)
48d93b8 
# Objective

- Globals are supposed to be available in vertex shader but that was
mistakenly removed in 0.13

## Solution

- Configure the visibility of the globals correctly

Fixes #12015
@Neopallium Neopallium mentioned this pull request Feb 27, 2024
Closed
@Lethja Lethja mentioned this pull request Mar 10, 2024
Merged
4 tasks
@jadedbay jadedbay mentioned this pull request Mar 16, 2024
Open
NiseVoid pushed a commit to NiseVoid/bevy that referenced this pull request Jul 8, 2024
@IceSentry @NiseVoid
Make Globals visible in vertex shaders (bevyengine#12032)
91f7c75 
# Objective

- Globals are supposed to be available in vertex shader but that was
mistakenly removed in 0.13

## Solution

- Configure the visibility of the globals correctly

Fixes bevyengine#12015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@Elabajaba Elabajaba Elabajaba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.13.1

Development

Successfully merging this pull request may close these issues.

Globals binding not available in vertex shader.

3 participants

@IceSentry @Elabajaba @alice-i-cecile