Make from_reflect_or_world
also try ReflectDefault
and improve some comments and panic messages
#12499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
from_reflect_or_world
is an internal utilty used in the implementations ofReflectComponent
andReflectBundle
to create aT
given a&dyn Reflect
by trying to useFromReflect
, and if that fails it falls back toReflectFromWorld
FromWorld
is not intuitive though: often it is implicitly implemented by derivingDefault
so people might not even be aware of it.ReflectFromWorld
are not directly correlated to what the user would have to do (reflectFromWorld
)Solution
ReflectDefault
in addition toReflectFromWorld
.Reflect*
types.Changelog
ReflectComponent
andReflectBundle
no longer requireT: FromReflect
but instead onlyT: Reflect
.ReflectComponent
andReflectBundle
will also work with types that only reflectedDefault
and notFromWorld
.Migration Guide
ReflectBundle::insert
now requires an additional&TypeRegistry
parameter.