Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example showcase wasm window settings patch #12608

Merged
merged 1 commit into from Apr 6, 2024

Conversation

rparrett
Copy link
Contributor

Objective

FIx this failed workflow: https://github.com/bevyengine/bevy/actions/runs/8367408952/job/22909715870#step:7:11

Solution

Make the required changes on fresh Bevy code and save a new patch

@rparrett rparrett requested a review from mockersf March 21, 2024 04:24
@SolarLiner SolarLiner added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples labels Mar 21, 2024
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested!

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 6, 2024
@mockersf mockersf added this pull request to the merge queue Apr 6, 2024
Merged via the queue into bevyengine:main with commit 6c485c8 Apr 6, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants