Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve output of example showcase patches CI workflow #12609

Merged
merged 5 commits into from Apr 22, 2024
Merged

Improve output of example showcase patches CI workflow #12609

merged 5 commits into from Apr 22, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Mar 21, 2024 •
edited

Objective

Fixes #12539

Improve this CI output.

Solution

  • Don't stop after the first failure.
  • Print the filename of the patch(es) that failed.
  • Clean up an unused package install while we're at it.

Tested over here: rparrett#20

@SolarLiner SolarLiner added C-Enhancement A new feature A-Meta About the project itself labels Mar 21, 2024
@BD103 BD103 added A-Build-System Related to build systems or continuous integration and removed A-Meta About the project itself labels Mar 21, 2024
BD103
BD103 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you mind rebasing onto main, so it's up to date?

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 22, 2024
@mockersf mockersf added this pull request to the merge queue Apr 22, 2024
Merged via the queue into bevyengine:main with commit e1ee6af Apr 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Enhancement A new feature S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error messages when check-example-showcase-patches-still-work CI job fails
4 participants
@rparrett @mockersf @BD103 @SolarLiner