New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI border artifacts caused by incorrect blending #12725
Fix UI border artifacts caused by incorrect blending #12725
Conversation
These artifacts are actually from the underlaying button image: This PR only makes them more obvious. I believe this is another issue we need to deal with (which may need a separate PR). I'll take a look. |
The artifacts brought up by @chompaa are due to how we draw borders. Given a rect, we extend the rect edge inwards to make the border, which has the exact same external edge as the rect (which we use to draw A possible solution to this is not to draw the Anyways, this is a separate issue. And, with some further tests, this PR is good to go. |
Is there anything I can do to move this along? Like working on tests? |
@asafigan I'm not sure. We may need to run all the UI related examples to make sure this isn't causing other issues. |
Fixes #12702.