Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FloatOrd into bevy_math #12732

Merged
merged 2 commits into from Mar 27, 2024
Merged

Move FloatOrd into bevy_math #12732

merged 2 commits into from Mar 27, 2024

Conversation

OneFourth
Copy link
Contributor

Objective

Solution

  • Move the float_ord.rs file to bevy_math
  • Change any bevy_utils::FloatOrd statements to bevy_math::FloatOrd

Changelog

  • Moved FloatOrd from bevy_utils to bevy_math

Migration Guide

  • References to bevy_utils::FloatOrd should be changed to bevy_math::FloatOrd

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations A-Utils Utility functions and types labels Mar 26, 2024
@alice-i-cecile alice-i-cecile mentioned this pull request Mar 26, 2024
Merged
bushrat011899
bushrat011899 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. bevy_utils is a necessary evil for unsorted code (IMO), so anything that has a better home should go there.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 27, 2024
james7132
james7132 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind resolving the conflicts?

@james7132 james7132 added this pull request to the merge queue Mar 27, 2024
Merged via the queue into bevyengine:main with commit 4508077 Mar 27, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move FloatOrd into bevy_math
4 participants
@OneFourth @bushrat011899 @james7132 @alice-i-cecile