Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguities causing a crash #12780

Merged
merged 4 commits into from Mar 29, 2024

Conversation

s-puig
Copy link
Contributor

@s-puig s-puig commented Mar 29, 2024

Objective

  • Disabling some plugins causes a crash due to ambiguities relying in feature flags and not checking if both plugins are enabled causing code like this to crash:

app.add_plugins(DefaultPlugins.build().disable::<AnimationPlugin>())

Solution

  • Check if plugins were added before ambiguities.
  • Move bevy_gizmos ambiguities from bevy_internal to bevy_gizmos since they already depend on them.

@alice-i-cecile
Copy link
Member

#1255 please :( Good fixes though!

@matiqo15 matiqo15 added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Mar 29, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 29, 2024
Merged via the queue into bevyengine:main with commit 7363268 Mar 29, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants