Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor non-eventloop setup logic from WinitPlugin into WinitCorePlugin #12786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor non-eventloop setup logic from WinitPlugin into WinitCorePlugin #12786

wants to merge 1 commit into from

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Mar 29, 2024 •
edited

Objective

  • Set up winit in an app without creating an event loop. I do this in bevy_worldswap to create secondary apps that can be swapped into the event loop created by the primary/original app.

Solution

  • Refactor non-eventloop setup logic from WinitPlugin into WinitCorePlugin.

Changelog

  • Added WinitCorePlugin that contains non-eventloop setup logic for winit.

@james7132 james7132 added A-Windowing Platform-agnostic interface layer to run your app in C-Usability A simple quality-of-life change that makes Bevy easier to use labels Mar 29, 2024
@UkoeHB UkoeHB mentioned this pull request Apr 3, 2024
Closed
6 tasks
jgayfer
jgayfer approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@jgayfer jgayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with winit, but this looks like a win for isolating a subset of functionality 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgayfer jgayfer jgayfer approved these changes

@Shatur Shatur Shatur approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@UkoeHB @jgayfer @Shatur @james7132