Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't make an AssetServer in AssetPlugin if one already exists #12790

Closed
wants to merge 2 commits into from
Closed

Don't make an AssetServer in AssetPlugin if one already exists #12790

wants to merge 2 commits into from

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Mar 29, 2024

Objective

  • Allow reusing asset servers between apps.

Solution

  • Don't make a new AssetServer in AssetPlugin if the app already has an AssetServer resource.

Changelog

  • AssetPlugin will no longer make an AssetServer if an AssetServer resource already exists in the app.

Migration Guide

AssetPlugin will no longer make an AssetServer if an AssetServer resource already exists in the app.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds labels Mar 29, 2024
@UkoeHB UkoeHB mentioned this pull request Apr 3, 2024
Closed
6 tasks
@UkoeHB
Copy link
Contributor Author

UkoeHB commented Apr 16, 2024

Closing due to won't fix conclusion from #12860.

@UkoeHB UkoeHB closed this Apr 16, 2024
@UkoeHB UkoeHB deleted the assetserver branch June 5, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shatur Shatur Shatur approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UkoeHB @Shatur @alice-i-cecile