Add RemovedComponentEvents::iter
#12815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's useful to iterate over removed entities. For example, in my library https://github.com/projectharmonia/bevy_replicon I need it to iterate over all removals to replicate them over the network. Right now we do lookups, but it would be more convenient and faster to just iterate.
pablo-lua
added
A-ECS
pablo-lua
approved these changes
Mar 31, 2024
Co-authored-by: Pablo Reinhardt <126117294+pablo-lua@users.noreply.github.com>
UkoeHB
approved these changes
Mar 31, 2024
pablo-lua
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Apr 1, 2024
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
# Objective Sometimes it's useful to iterate over removed entities. For example, in my library [bevy_replicon](https://github.com/projectharmonia/bevy_replicon) I need it to iterate over all removals to replicate them over the network. Right now we do lookups, but it would be more convenient and faster to just iterate over all removals. ## Solution Add `RemovedComponentEvents::iter`. --- ## Changelog ### Added - `RemovedComponentEvents::iter` to iterate over all removed components. --------- Co-authored-by: Pablo Reinhardt <126117294+pablo-lua@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Sometimes it's useful to iterate over removed entities. For example, in my library bevy_replicon I need it to iterate over all removals to replicate them over the network.
Right now we do lookups, but it would be more convenient and faster to just iterate over all removals.
Solution
Add
RemovedComponentEvents::iter.Changelog
Added
RemovedComponentEvents::iterto iterate over all removed components.