Remove redundant imports #12817
Merged
Remove redundant imports #12817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found using `cargo check --workspace --tests`.
Found using `cargo check --workspace --examples`.
BD103
added
C-Examples
james7132
approved these changes
Apr 1, 2024
james7132
added
A-Cross-Cutting
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
# Objective - The `ImePreedit` component from [`text_input`](https://github.com/bevyengine/bevy/blob/50699ecf76800e5b1b31bd9b6845b30e4ede5e32/examples/input/text_input.rs#L126-L127) appears to be unused. - This was found by running `cargo check --workspace --examples`, originally as part of #12817. ## Solution - Remove it :)
NthTensor
approved these changes
Apr 1, 2024
pablo-lua
added
S-Ready-For-Final-Review
|
Removed the label because it's a draft |
Yup, I just need to update the CI and I'll mark it as ready. |
pablo-lua
added
the
S-Ready-For-Final-Review
|
I added a check into CI, but it's not amazing. I think the tool needs a refactoring, but for now this PR is ready to go. |
kristoff3r
approved these changes
Apr 1, 2024
mockersf
reviewed
Apr 1, 2024
mockersf
removed
the
S-Ready-For-Final-Review
Co-authored-by: François Mockers <francois.mockers@vleue.com>
mockersf
approved these changes
Apr 1, 2024
mockersf
added
the
S-Ready-For-Final-Review
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
…ngine#12818) # Objective - The `ImePreedit` component from [`text_input`](https://github.com/bevyengine/bevy/blob/50699ecf76800e5b1b31bd9b6845b30e4ede5e32/examples/input/text_input.rs#L126-L127) appears to be unused. - This was found by running `cargo check --workspace --examples`, originally as part of bevyengine#12817. ## Solution - Remove it :)
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
# Objective - There are several redundant imports in the tests and examples that are not caught by CI because additional flags need to be passed. ## Solution - Run `cargo check --workspace --tests` and `cargo check --workspace --examples`, then fix all warnings. - Add `test-check` to CI, which will be run in the check-compiles job. This should catch future warnings for tests. Examples are already checked, but I'm not yet sure why they weren't caught. ## Discussion - Should the `--tests` and `--examples` flags be added to CI, so this is caught in the future? - If so, bevyengine#12818 will need to be merged first. It was also a warning raised by checking the examples, but I chose to split off into a separate PR. --------- Co-authored-by: François Mockers <francois.mockers@vleue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
cargo check --workspace --testsandcargo check --workspace --examples, then fix all warnings.test-checkto CI, which will be run in the check-compiles job. This should catch future warnings for tests. Examples are already checked, but I'm not yet sure why they weren't caught.Discussion
--testsand--examplesflags be added to CI, so this is caught in the future?ImePreeditcomponent fromtext_inputexample #12818 will need to be merged first. It was also a warning raised by checking the examples, but I chose to split off into a separate PR.