Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundent information and optimize dynamic allocations in Table #12929

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Remove redundent information and optimize dynamic allocations in Table #12929

wants to merge 64 commits into from

Commits on Apr 5, 2024

  1. added blob_array

    @Adamkob12
    Adamkob12 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5564de5 View commit details
    Browse the repository at this point in the history

  2. seperated column into different file

    @Adamkob12
    Adamkob12 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7d74489 View commit details
    Browse the repository at this point in the history

  3. implemented ThinArrayPtr, not tested yet

    @Adamkob12
    Adamkob12 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f5baf43 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. defined new Column type, working on adjusting Table

    @Adamkob12
    Adamkob12 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    8ddf250 View commit details
    Browse the repository at this point in the history

  2. added almost all the methods needed for ColumnWIP, need refactor now … 

    …to get rid of code duplication
    @Adamkob12
    Adamkob12 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ec4fb50 View commit details
    Browse the repository at this point in the history

  3. refactor + cleaning up methods and adding a couple more to ColumnWIP

    @Adamkob12
    Adamkob12 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c2aed7d View commit details
    Browse the repository at this point in the history

  4. renamed ColumnWIP to Column and deleted previous Column

    @Adamkob12
    Adamkob12 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    e4bb500 View commit details
    Browse the repository at this point in the history

  5. Revert "renamed ColumnWIP to Column and deleted previous Column" 

    This reverts commit e4bb500.

realize we need the old column back, the new one will be only for tables
    @Adamkob12
    Adamkob12 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2e7c06c View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. no errors

    @Adamkob12
    Adamkob12 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    eb51eb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. fixing bugs, passed all tests expcept one

    @Adamkob12
    Adamkob12 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    bb77e01 View commit details
    Browse the repository at this point in the history

  2. Table::alloc_columns

    @Adamkob12
    Adamkob12 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    572a289 View commit details
    Browse the repository at this point in the history

  3. fix some warnings

    @Adamkob12
    Adamkob12 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d0b5b9d View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. checkpoint

    @Adamkob12
    Adamkob12 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    dbd477a View commit details
    Browse the repository at this point in the history

  2. trying to solve abort (because of double free?) at test `panic_while_… 

    …overwriting_component`
    @Adamkob12
    Adamkob12 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4809fe0 View commit details
    Browse the repository at this point in the history

  3. fixed double drop in unwind

    @Adamkob12
    Adamkob12 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3d09567 View commit details
    Browse the repository at this point in the history

  4. all tests passed

    @Adamkob12
    Adamkob12 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b522b3a View commit details
    Browse the repository at this point in the history

  5. chipping away at TODOs

    @Adamkob12
    Adamkob12 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2c76208 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. docs

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    20285b4 View commit details
    Browse the repository at this point in the history

  2. doc nits

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3aaebf2 View commit details
    Browse the repository at this point in the history

  3. added benchmark for adding removing a (very) lot of components per en… 

    …tity
    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a20de1a View commit details
    Browse the repository at this point in the history

  4. remove duplicate test

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9c6d229 View commit details
    Browse the repository at this point in the history

  5. clippy

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6782cc7 View commit details
    Browse the repository at this point in the history

  6. typos

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1c52357 View commit details
    Browse the repository at this point in the history

  7. doc tests

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d6467c1 View commit details
    Browse the repository at this point in the history

  8. ci

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ddaf16f View commit details
    Browse the repository at this point in the history

  9. ci

    @Adamkob12
    Adamkob12 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    568cc42 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. fixed double free

    @Adamkob12
    Adamkob12 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9d55340 View commit details
    Browse the repository at this point in the history

  2. fix some ci (i think the other is bugged)

    @Adamkob12
    Adamkob12 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5ef9e54 View commit details
    Browse the repository at this point in the history

  3. expand thinarrayptr in debug mode

    @Adamkob12
    Adamkob12 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    fb794cc View commit details
    Browse the repository at this point in the history

  4. docs

    @Adamkob12
    Adamkob12 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3153f28 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Merge branch 'main' into remove_lens_and_caps_from_table

    @Adamkob12
    Adamkob12 committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    1c1690e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. x

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    de25be0 View commit details
    Browse the repository at this point in the history

  2. Update crates/bevy_ecs/src/storage/thin_array_ptr.rs 

    Co-authored-by: James Liu <contact@jamessliu.com>
    @Adamkob12 @james7132
    Adamkob12 and james7132 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5732351 View commit details
    Browse the repository at this point in the history

  3. x

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1d44fdd View commit details
    Browse the repository at this point in the history

  4. x

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    faec660 View commit details
    Browse the repository at this point in the history

  5. expand add_remove_very_big benchmark

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0ecff6b View commit details
    Browse the repository at this point in the history

  6. added ZSTs to add_remove_very_big benchmark

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8004d80 View commit details
    Browse the repository at this point in the history

  7. checking why test failed

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ce583c6 View commit details
    Browse the repository at this point in the history

  8. fixed test fail

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8ec9eca View commit details
    Browse the repository at this point in the history

  9. docs

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ac9d9f2 View commit details
    Browse the repository at this point in the history

  10. merge main into branch

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    976c553 View commit details
    Browse the repository at this point in the history

  11. typo

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2a21b6b View commit details
    Browse the repository at this point in the history

  12. docs

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    abaa9a0 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into remove_lens_and_caps_from_table

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    96b3e79 View commit details
    Browse the repository at this point in the history

  14. Update crates/bevy_ecs/src/storage/thin_array_ptr.rs 

    Co-authored-by: James Liu <contact@jamessliu.com>
    @Adamkob12 @james7132
    Adamkob12 and james7132 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7f62022 View commit details
    Browse the repository at this point in the history

  15. added inline

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3a13021 View commit details
    Browse the repository at this point in the history

  16. abort on allocation panic

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    96a3602 View commit details
    Browse the repository at this point in the history

  17. x

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    49d1807 View commit details
    Browse the repository at this point in the history

  18. x

    @Adamkob12
    Adamkob12 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    fc8f66f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. renamed some methods, fixed some docs

    @Adamkob12
    Adamkob12 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e150dca View commit details
    Browse the repository at this point in the history

  2. added back some public methods that were removed from Column

    @Adamkob12
    Adamkob12 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    451198d View commit details
    Browse the repository at this point in the history

  3. solve merge conflicts

    @Adamkob12
    Adamkob12 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    b5f6ddb View commit details
    Browse the repository at this point in the history

  4. ci

    @Adamkob12
    Adamkob12 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    cba8158 View commit details
    Browse the repository at this point in the history

  5. fix edgecase where components wouldn't be dropped when removed

    @Adamkob12
    Adamkob12 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    81b47fe View commit details
    Browse the repository at this point in the history

  6. docs nits

    @Adamkob12
    Adamkob12 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    4f35607 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. pub -> pub(crate) in some methods in Table and ThinColumn | docs

    @Adamkob12
    Adamkob12 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    494b85a View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Fix ZST components not being dropped, test to make sure

    @Adamkob12
    Adamkob12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d44fe5b View commit details
    Browse the repository at this point in the history

  2. docs

    @Adamkob12
    Adamkob12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    22911a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bevyengine:main' into remove_lens_and_caps_from_table

    @Adamkob12
    Adamkob12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    fbf6abf View commit details
    Browse the repository at this point in the history

  4. LMerge remote-tracking branch 'refs/remotes/origin/remove_lens_and_ca… 

    …ps_from_table' into remove_lens_and_caps_from_table
    @Adamkob12
    Adamkob12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    457b8cc View commit details
    Browse the repository at this point in the history

  5. clippy

    @Adamkob12
    Adamkob12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a109aef View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into remove_lens_and_caps_from_table

    @Adamkob12
    Adamkob12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    99826e6 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. x

    @Adamkob12
    Adamkob12 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ed8195b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/remove_lens_and_cap… 

    …s_from_table' into remove_lens_and_caps_from_table
    @Adamkob12
    Adamkob12 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3845074 View commit details
    Browse the repository at this point in the history