Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the system task span #12950

Merged
merged 3 commits into from Apr 13, 2024
Merged

Remove the system task span #12950

merged 3 commits into from Apr 13, 2024

Conversation

james7132
Copy link
Member

Objective

The system task span is pretty consistent in how much time it uses, so all it adds is overhead/additional bandwidth when profiling.

Solution

Remove it.

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Apr 13, 2024
@james7132 james7132 requested a review from hymm April 13, 2024 05:55
@james7132 james7132 added this pull request to the merge queue Apr 13, 2024
Merged via the queue into bevyengine:main with commit 60e400b Apr 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@re0312 re0312 re0312 approved these changes

@hymm hymm Awaiting requested review from hymm

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@james7132 @mockersf @re0312