-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Vec3A for 3D bounding volumes and raycasts #13087
Conversation
Do we have a good test to best mark this on? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like straightforward changes, I haven't spotted any problems.
} else { | ||
(aabb.max.z, aabb.min.z) | ||
}; | ||
let positive = self.direction.signum().cmpgt(Vec3A::ZERO); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the signum needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the signum it'll break on 0 vs -0, signum always turns it into 1 or -1 ... Would be nice if glam had a function to get a BVec3A for the signs directly tho 🤔
Objective
Solution
Vec3A
internally for bounding volumes, acceptingInto<Vec3A>
wherever possibleChangelog
Vec3A
for 3D bounding volumes and raycastsMigration Guide
Vec3A
types internally, return values from methods on them now returnVec3A
instead ofVec3