Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore dragons to their seat of power #13124

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Restore dragons to their seat of power #13124

merged 1 commit into from
Apr 28, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Apr 28, 2024

Objective

  • There is an unfortunate lack of dragons in the meshlet docs.
  • Dragons are symbolic of majesty, power, storms, and meshlets.
  • A dragon habitat such as our docs requires cultivation to ensure each winged lizard reaches their fullest, fiery selves.

Solution

  • Fix the link to the dragon image.
    • The link originally targeted the meshlet branch, but that was later deleted after it was merged into main.

Changelog

  • Added a dragon back into the MeshletPlugin documentation.

@BD103 BD103 requested a review from JMS55 April 28, 2024 02:58
@BD103 BD103 added C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Apr 28, 2024
@BD103
Copy link
Member Author

BD103 commented Apr 28, 2024

For completely serious and non-humorous reasons, please pretend that this PR is labeled C-Needs-Release-Notes. 🐉

@BD103 BD103 changed the title Fix image of meshlet dragon Restore dragons to their seat of power Apr 28, 2024
JMS55
JMS55 approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BD103 BD103 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 28, 2024
@mockersf mockersf added this pull request to the merge queue Apr 28, 2024
Merged via the queue into bevyengine:main with commit 45bb625 Apr 28, 2024
32 checks passed
@BD103 BD103 deleted the meshlet-dragon branch April 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiseVoid NiseVoid NiseVoid approved these changes

@mockersf mockersf mockersf approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BD103 @NiseVoid @mockersf @JMS55