Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config_fast_builds.toml #13136

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Improve config_fast_builds.toml #13136

merged 7 commits into from
Apr 30, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Apr 29, 2024

Objective

  • config_fast_builds.toml could use some general improvements and additions.
    • Mold is a modern linker with serious performance improvements that provides a good alternative to LLD.
  • This is exactly the same as Improve config_fast_builds.toml聽#12949; I accidentally deleted the branch. 馃槄

Solution

  • Majorly improve config_fast_builds.toml.
    • Add further documentation.
    • Add a section for the alternative Mold linker, which is much faster.
    • Disable nightly options by default so that developers running stable can copy the file without having to edit it. (Nightly is still recommended, but this is following suite with rustfmt.toml.)

Changelog

  • Majorly improved config_fast_builds.toml documentation and added Mold linker.

@BD103
feat: majorly improve config_fast_builds.toml
b9195db 
Add much more in-depth docs, add a section about the Mold / Sold linker, and disable nightly options by default.
@BD103
feat: greatly improve opening information
49999bb
@BD103
fix: sold is available under mit license
1f97a75
@BD103
fix: remain neutral on platform support
c8b9047 
My original intention was that compiling software from scratch is less friendly; I didn't intend on making it sound like I liked MacOS less. In the end, it's better just to remove the line anyways.
@BD103
fix: remove sold from configuration
c33e917
@BD103
Merge branch 'main' into lld-ci
98066c8
@BD103
Merge branch 'main' into lld-ci
73bc300
@BD103 BD103 added C-Docs An addition or correction to our documentation C-Performance A change motivated by improving speed, memory usage or compile times C-Usability A simple quality-of-life change that makes Bevy easier to use A-Cross-Cutting Impacts the entire engine labels Apr 29, 2024
@BD103 BD103 requested a review from mockersf April 29, 2024 12:54
@BD103
Copy link
Member Author

BD103 commented Apr 30, 2024

@SkiFire13 previously approved the old PR, but I'm going to wait for one more reviewer because there have been a few changes since then.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 30, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 30, 2024
Merged via the queue into bevyengine:main with commit dac66e8 Apr 30, 2024
60 checks passed
@BD103 BD103 deleted the better-config-toml branch April 30, 2024 20:38
@BD103 BD103 mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Docs An addition or correction to our documentation C-Performance A change motivated by improving speed, memory usage or compile times C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BD103 @alice-i-cecile @mockersf