Fix Interaction not resetting to None sometimes #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Touch input appears to be completely broken ... not due to this pr, but due to the recent move to using window.cursor_position (which touch does not set). I think we'll want to incorporate the touch location too (in a separate pr). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects two bugs in
ui_focus_system:Interaction::Clickeduntil the next mouse clickFocusPolicy::Pass, such as when they get covered by new nodesI noticed that touch input is using
just_releasedinstead ofjust_pressedfor clicking, which means that the 1st issue may have been a feature for them. With this PR, the buttons would no longer stay stuck in theClickedstate after any released touch. If that behaviour was intended I can easily re-introduce it.