Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new format for ci config file #13154

Merged
merged 3 commits into from
May 2, 2024
Merged

new format for ci config file #13154

merged 3 commits into from
May 2, 2024

Conversation

mockersf
Copy link
Member

Objective

  • Current config file is hard to extend

Solution

  • Instead of an hard coded list of field, the file now has a list of (frame, event), and will deal with know events (exiting or taking a screenshot), or send an event for others that can be dealt by third party plugins

@mockersf mockersf added A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps labels Apr 30, 2024
BD103
BD103 approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few small requests, but nothing blocking! 👍

crates/bevy_dev_tools/src/ci_testing.rs Outdated Show resolved Hide resolved
crates/bevy_dev_tools/src/ci_testing.rs Outdated Show resolved Hide resolved
crates/bevy_dev_tools/src/ci_testing.rs Outdated Show resolved Hide resolved
@IceSentry
Copy link
Contributor

Does this mean we could add events like moving a cursor, a mouse press or a button press? That would be useful to test some things like for example switching to each SSAO quality levels and take a screenshot of each.

@mockersf
Copy link
Member Author

mockersf commented May 2, 2024

Yup that's the plan!

@BD103 BD103 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 2, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels May 2, 2024
@alice-i-cecile
Copy link
Member

@mockersf CI failure seems related and persistent, if not particularly clear.

@mockersf mockersf added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 2, 2024
@mockersf
Copy link
Member Author

mockersf commented May 2, 2024

oops, forgot the wasm runner case
@alice-i-cecile should be fixed now

@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2024
Merged via the queue into bevyengine:main with commit fd4589d May 2, 2024
28 checks passed
@mockersf mockersf deleted the ci-testing-any-event branch May 17, 2024 21:15
@mockersf mockersf restored the ci-testing-any-event branch May 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mockersf @IceSentry @alice-i-cecile @BD103