Reorganize issue labels

[alice-i-cecile]

Objective

The existing labels are inadequate for keeping track of the state of work at a glance. They're also inadequate for finding work that's at an appropriate difficulty level to either implement or review.

Solution

• Add a complete set of difficulty labels
• Move S-Controversial into its own category
• Adding a complete set of controversiality labels, adding X-Uncontroversial and X-Contentious
• Add a complete set of status labels: adding S-Needs-Testing, S-Needs-Review and S-Waiting-On-Author
• Update CONTRIBUTING.md to reflect the new scheme

[cBournhonesque]

I really like this!
Should we still keep D-Good-First-Issue? Isn't it a special label from github to help users discover issues?

[alice-i-cecile]

I really like this! Should we still keep D-Good-First-Issue? Isn't it a special label from github to help users discover issues?

good first issue is: we're already breaking convention so it doesn't work. IIRC Hacktoberfest allows us to specify our own label instead. I think that being able to unify this across issues and PRs is valuable enough to swap away.

[BD103]

• Adding a complete set of controversiality labels, adding X-Uncontroversial and X-Contentious

Could you add one more, X-Resolved? This could be used to specify a previously controversial PR / issue that either Cart made a final decision on or the community came to a consensus on.

[MrGVSV]

Nit: Should we link to the SME page?

[alice-i-cecile]

I think that's not worth it here. When we split this out into a proper book I'll do a pass on cross-linking though.

[alice-i-cecile]

@BD103 I've added your suggestion in the form of X-Blessed: I think that's clearer in the cases where there's an endorsed design doc or RFC that we're working off of.

[alice-i-cecile]

We have no objections from the other maintainers and a broad sign off from @cart, so I'm going to merge this now and start tweaking the labels to match.

[BD103]

I think CI is failing because Rust 1.78 just got released, stabilizing a new lint. I'll make a quick PR fixing this.

Edit: Alice beat me to it :P

[mockersf]

this removed the "good first issue" label, which is a standard and something GitHub trains people to search for. it was already a downgraded experience because we used "D-Good-First-Issue", but at least it was matching when people were searching for the label

[alice-i-cecile]

Perhaps we can swap to D-Good-First-Contribution?