Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI error on new color grading example #13180

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix CI error on new color grading example #13180

merged 1 commit into from
May 2, 2024

Conversation

alice-i-cecile
Copy link
Member

Objective

Fixes #13179

Solution

Obey clippy.

Commentary

I'm really confused why CI didn't fail on the initial PR merge here.

@alice-i-cecile alice-i-cecile changed the title Fix CI er er Fix CI error on new color grading example May 2, 2024
@alice-i-cecile alice-i-cecile added the C-Examples An addition or correction to our examples label May 2, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen P-Critical This must be fixed immediately or contributors or users will be severely impacted A-Build-System Related to build systems or continuous integration labels May 2, 2024
@alice-i-cecile alice-i-cecile requested a review from BD103 May 2, 2024 13:29
@alice-i-cecile
Copy link
Member Author

Closing in favor of #13181

@alice-i-cecile alice-i-cecile reopened this May 2, 2024
@alice-i-cecile
Copy link
Member Author

Other PR had a typo in the fix and was failing CI; merging this instead.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon labels May 2, 2024
@BD103 BD103 mentioned this pull request May 2, 2024
Closed
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit b2123ff May 2, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BD103 BD103 BD103 approved these changes

@pcwalton pcwalton Awaiting requested review from pcwalton

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy P-Critical This must be fixed immediately or contributors or users will be severely impacted S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is failing on new color_grading example
2 participants
@alice-i-cecile @BD103