Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use folder for example showcase reports and add show logs flag #13198

Merged
merged 1 commit into from
May 3, 2024
Merged

Use folder for example showcase reports and add show logs flag #13198

merged 1 commit into from
May 3, 2024

Conversation

IceSentry
Copy link
Contributor

Objective

  • The report_details flag currently dumps everything at the root of the repo which isn't ideal
  • When running the tool locally it's useful to see the logs as they appear

Solution

  • Add a flag to show the logs
  • Write all the report files to a folder

@IceSentry IceSentry added the A-Dev-Tools Tools used to debug Bevy applications. label May 3, 2024
@IceSentry IceSentry requested a review from mockersf May 3, 2024 04:07
@alice-i-cecile alice-i-cecile added the C-Usability A simple quality-of-life change that makes Bevy easier to use label May 3, 2024
@alice-i-cecile alice-i-cecile requested a review from BD103 May 3, 2024 13:02
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 3, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 3, 2024
Merged via the queue into bevyengine:main with commit 6ca1b07 May 3, 2024
31 checks passed
@IceSentry IceSentry deleted the example-showcase-logs branch May 3, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf Awaiting requested review from mockersf

@BD103 BD103 Awaiting requested review from BD103

Assignees
No one assigned
Labels
A-Dev-Tools Tools used to debug Bevy applications. C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IceSentry @kristoff3r @alice-i-cecile