Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bevy_gltf crate build #13202

Merged
merged 3 commits into from
May 3, 2024
Merged

fix bevy_gltf crate build #13202

merged 3 commits into from
May 3, 2024

Conversation

ycysdf
Copy link
Contributor

@ycysdf ycysdf commented May 3, 2024

Objective

Fixing bevy_gltf crate build fail when bevy_animation feature is disabled

Solution

Add missing bevy_animation feature

Add missing `bevy_animation` feature
@kristoff3r
Copy link
Contributor

I think you placed the cfg on the wrong argument, it needs to be on the AnimationContext. You also need to run cargo fmt afterwards.

@ycysdf
Copy link
Contributor Author

ycysdf commented May 3, 2024

I think you placed the cfg on the wrong argument, it needs to be on the AnimationContext. You also need to run cargo fmt afterwards.

You're right.

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds A-Animation Make things move and change over time P-Compile-Failure A failure to compile Bevy apps labels May 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 3, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 3, 2024
Merged via the queue into bevyengine:main with commit 9d8f94d May 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Animation Make things move and change over time A-Assets Load files from disk to use for things like images, models, and sounds P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants