Separate state crate #13216
Merged
Separate state crate #13216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-state-crate
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
C-Breaking-Change
MiniaczQ
reviewed
May 3, 2024
|
Yeah, we should move the examples to a separate folder now :) |
MiniaczQ
approved these changes
May 3, 2024
There was a problem hiding this comment.
You need to update the publish.sh script, but otherwise this LGTM.
https://github.com/bevyengine/bevy/blob/main/tools/publish.sh
Done! |
MiniaczQ
approved these changes
May 6, 2024
alice-i-cecile
approved these changes
May 7, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
BD103
suggested changes
May 7, 2024
BD103
removed
the
S-Ready-For-Final-Review
BD103
approved these changes
May 7, 2024
BD103
added
the
S-Ready-For-Final-Review
MiniaczQ
approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alice-i-cecile
added
the
S-Adopt-Me
kristoff3r
reviewed
May 8, 2024
crates/bevy_ecs/macros/Cargo.toml
Outdated
| @@ -11,7 +11,7 @@ proc-macro = true | |||
| [dependencies] | |||
| bevy_macro_utils = { path = "../../bevy_macro_utils", version = "0.14.0-dev" } | |||
|
|
|||
| syn = { version = "2.0", features = ["full"] } | |||
| syn = "2.0" | |||
There was a problem hiding this comment.
This is a bad merge from main where the same thing was fixed. I think the merge might go through if this change is removed.
kristoff3r
reviewed
May 8, 2024
Co-authored-by: Kristoffer Søholm <k.soeholm@gmail.com>
MiniaczQ
approved these changes
May 9, 2024
alice-i-cecile
removed
the
S-Adopt-Me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Extracts the state mechanisms into a new crate called "bevy_state".
This comes with a few goals:
moving state into a new crate makes it easier to encapsulate as it's own feature, and easier to read and understand since it's no longer a single, massive file.
Solution
move the state-related elements from bevy_ecs to a new crate
Testing
Migration Guide
Since bevy_state is now gated behind the
bevy_statefeature, projects that use state but don't use thedefault-featureswill need to add that feature flag.Since it is no longer part of bevy_ecs, projects that use bevy_ecs directly will need to manually pull in
bevy_state, trigger the StateTransition schedule, and handle any of the elements that bevy_app currently sets up.