Fix incorrect workgroupBarrier and OOB array access in auto_exposure #13283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues in auto_exposure.wgsl:
storageBarrier()
was incorrectly used where aworkgroupBarrier()
should be used instead;histogram_shared
array would write beyond the 64th index, which is out of bounds.Solution
The first issue is fixed by using the appropriate workgroupBarrier instead;
The second issue is fixed by adding a range check before setting
histogram_shared[local_invocation_index] = 0u
.Testing
These changes were tested using the Xcode metal profiler, and I could not find any noticable change in compute shader performance.