Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Color Operations for Color #13285

Merged
merged 1 commit into from
May 14, 2024

Commits on May 13, 2024

  1. Implement Color Operations for Color

    Delegates to internal type when possible, otherwise uses `ChosenColorSpace` as an intermediary. This _will_ double convert, but this is considered an acceptable compromise since use of specific colour types in performance critical colour operations is already encouraged.
    
     `ChosenColorSpace` is `Oklcha` since it's perceptually uniform while supporting all required operations, and in my opinion is the "best" for this task. Using different spaces for different operations will make documenting this double-conversion behaviour more challenging.
    
    Call out explicitly why `Oklcha` is used for operations requiring conversion.
    bushrat011899 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f2e9c13 View commit details
    Browse the repository at this point in the history