Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lava emissive strength in depth of field example #13449

Merged
merged 1 commit into from
May 21, 2024
Merged

fix lava emissive strength in depth of field example #13449

merged 1 commit into from
May 21, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented May 21, 2024 •
edited

Objective

Solution

  • Change the emissive value in the material in the glb file from 20000 to 20

Testing

  • Run the example depth_of_field

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels May 21, 2024
Elabajaba
Elabajaba approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@Elabajaba Elabajaba left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, from a quick test it looks about the same strength as it was in the screenshots from the depth of field PR #13009

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 21, 2024
@alice-i-cecile
Copy link
Member

Tested locally before and after: looks much much more reasonable now.

@mockersf mockersf added this pull request to the merge queue May 21, 2024
Merged via the queue into bevyengine:main with commit 5a1c62f May 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elabajaba Elabajaba Elabajaba approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @alice-i-cecile @Elabajaba