Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unload unused images that are RenderAssetUsages::RENDER_WORLD #13609

Merged
merged 1 commit into from
May 31, 2024
Merged

unload unused images that are RenderAssetUsages::RENDER_WORLD #13609

merged 1 commit into from
May 31, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Remove their bind group when the handles are unused

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-Assets Load files from disk to use for things like images, models, and sounds labels May 31, 2024
@mockersf mockersf added this to the 0.14 milestone May 31, 2024
@mockersf mockersf requested a review from JMS55 May 31, 2024 16:50
@mockersf mockersf mentioned this pull request May 31, 2024
Closed
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 31, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 31, 2024
Merged via the queue into bevyengine:main with commit ce46d52 May 31, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

RenderAssetUsages::RENDER_WORLD assets are not cleaned when their handles are dropped
4 participants
@mockersf @alice-i-cecile @IceSentry @JMS55