Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view.inverse_clip_from_world should be world_from_clip #13756

Merged
merged 1 commit into from
Jun 9, 2024
Merged

view.inverse_clip_from_world should be world_from_clip #13756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bevy_gizmos/src/lines.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ fn vertex(vertex: VertexInput) -> VertexOutput {
let near_clipping_plane_height = length(pos0.xyz - pos1.xyz);

// We can't use vertex.position_X because we may have changed the clip positions with clip_near_plane
let position_a = view.inverse_clip_from_world * clip_a;
let position_b = view.inverse_clip_from_world * clip_b;
let position_a = view.world_from_clip * clip_a;
let position_b = view.world_from_clip * clip_b;
let world_distance = length(position_a.xyz - position_b.xyz);

// Offset to compensate for moved clip positions. If removed dots on lines will slide when position a is ofscreen.
Expand Down