add helper method Query::with_entity #13764
Draft
+46
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While I'm writing systems, I frequently find myself suddenly wanting to have access to the
Entity
that I'm iterating over with aQuery<&MyComp>
- so I have to refactor toQuery<(Entity, &MyComp)>
. This means changing the parameter type and other iteration sites over the same query, even if those sites don't use theEntity
.Solution
This PR adds a convenience method,
.with_entity()
analogous to e.g..enumerate()
onIterator
- it returns aQueryLens
over the same data, but withEntity
added to the data selector (in other words, it turns aQuery<D, F>
into aQueryLens<(Entity, D), F>
).Testing
transmute_lens_filtered
but without the need to specify generic types as a callerChangelog
Query::with_entity()
convenience function that returns aQueryLens
over the same results but also including theEntity
id