Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an illustration to the compass direction docs (issue 13664) #13788

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Added an illustration to the compass direction docs (issue 13664) #13788

merged 3 commits into from
Jun 10, 2024

Conversation

Wuketuke
Copy link
Contributor

@Wuketuke Wuketuke commented Jun 10, 2024 •
edited by alice-i-cecile
Loading

i based the design on @mgi388 in the discussion about the issue.
i added the illustration in such a way that it shows up when you hover your mouse over the type, i hope this is what was meant by the issue
no unit tests were added bc obviously

Fixes #13664

@Wuketuke
Copy link
Contributor Author

i forgot to add "ignore" to the documentation (bc rust unit tests documentation like a chad)

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Math Fundamental domain-agnostic mathematical operations labels Jun 10, 2024
@alice-i-cecile
Copy link
Member

Delightful :D

@alice-i-cecile
Copy link
Member

FYI only "fixes" and "closes" work as magic keywords: I edited your post from "solves" to link the issue properly :)

@Wuketuke Wuketuke closed this Jun 10, 2024
@Wuketuke Wuketuke deleted the issue_13664 branch June 10, 2024 12:20
@alice-i-cecile
Copy link
Member

Wait, why did you close this? This was good stuff and I was about to merge it :)

@Wuketuke
Copy link
Contributor Author

Wuketuke commented Jun 10, 2024 •
edited
Loading

@alice-i-cecile what no i didnt close it on purpose
edit: i think this is bc i restructured my fork, and that messed up the pr. but it was an accident, i hope we can sort this out

@Wuketuke Wuketuke restored the issue_13664 branch June 10, 2024 17:09
@alice-i-cecile
Copy link
Member

Yep, it looks like it closed this out automatically when the branch was deleted :) I've reopened this now, merging!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 10, 2024
Merged via the queue into bevyengine:main with commit 2c5959a Jun 10, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an illustration to the compass direction docs
2 participants
@Wuketuke @alice-i-cecile