Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to glam 0.28 #13792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update to glam 0.28 #13792

wants to merge 2 commits into from
+9 −9

Conversation

superdump
Copy link
Contributor

@superdump superdump commented Jun 10, 2024 •
edited
Loading

NOTE: This depends on encase and hexasphere being updated to use glam 0.28 as well!

Objective

  • Update glam to 0.28. Adds AArch64 NEON optimizations.

Testing

I tested many_cubes --benchmark on an M1 Max. Frustum culling sees a 25% decrease in media frame time:

Screenshot 2024-06-10 at 13 06 59

Overall frame time when run through tracy didn't change much, oddly, as when running without tracy I saw about a 25% overall frame time reduction from eyeballing the frame times being printed to the terminal.

Changelog

Migration Guide

@superdump
Update to glam 0.28
6a849cf 
Adds AArch64 NEON optimizations.
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Jun 10, 2024
@alice-i-cecile alice-i-cecile added C-Performance A change motivated by improving speed, memory usage or compile times A-Math Fundamental domain-agnostic mathematical operations S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Blocked This cannot move forward until something else changes labels Jun 10, 2024
@alice-i-cecile
Copy link
Member

We're blocked on hexasphere and encase still, correct?

@alice-i-cecile alice-i-cecile added the C-Dependencies A change to the crates that Bevy depends on label Jun 10, 2024
@superdump
Copy link
Contributor Author

superdump commented Jun 10, 2024 •
edited
Loading

We're blocked on hexasphere and encase still, correct?

Yup, added to the description now. CI will be very broken until they are updated.

@alice-i-cecile alice-i-cecile removed the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jun 10, 2024
@waywardmonkeys
Copy link
Contributor

teoxoy/encase#73

@mnmaita mnmaita mentioned this pull request Jun 14, 2024
Merged
@mnmaita
Copy link
Member

mnmaita commented Jun 14, 2024

Pushed OptimisticPeach/hexasphere#20. Hopefully we also get a new tag on hexasphere.

@mnmaita
Copy link
Member

mnmaita commented Jun 14, 2024 •
edited
Loading

hexasphere v13.0.0 is out now with the glam version bump (that was fast!).

This was referenced Jun 17, 2024
Closed
Closed
@teoxoy
Copy link
Contributor

teoxoy commented Jun 22, 2024

encase v0.9 is up on crates.io

@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Blocked This cannot move forward until something else changes labels Jun 22, 2024
This was referenced Jun 24, 2024
Closed
Closed
Closed
@janhohenheim janhohenheim added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Dependencies A change to the crates that Bevy depends on C-Performance A change motivated by improving speed, memory usage or compile times S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@superdump @alice-i-cecile @waywardmonkeys @mnmaita @teoxoy @janhohenheim