Revert Align Scene::write_to_world_with to match DynamicScene::write_to_world_with #13800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite_to_world_with` (bevyengine#13714)" This reverts commit 1f61c26.
alice-i-cecile
added
D-Trivial
|
Sorry @dmyyy, I should have spotted this in review! I'm going to revert for now, but do ping us with a new version. |
pcwalton
approved these changes
Jun 10, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Scene::write_to_world_withto matchDynamicScene::write_to_world_with#13714 broke scenes pretty seriouslySolution
Revert it. We can redo this PR once the behavior is fixed.