Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split event.rs into a full module. #13801

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Split event.rs into a full module. #13801

merged 2 commits into from
Jun 10, 2024

Conversation

BobG1983
Copy link
Contributor

Objective

  • Split the bevy_ecs::events module so it's easier to work with

Solution

  • Split the event.rs file across multiple files, made sure all tests passed, and exports from the module were the same as previous

Testing

  • All automated tests pass.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 10, 2024
@BobG1983 BobG1983 changed the title Split the event.rs into a full module. Split event.rs into a full module. Jun 10, 2024
alice-i-cecile
alice-i-cecile approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer. 1500 lines is too many lines, especially when there are nice logical divisions.

@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples X-Uncontroversial This work is generally agreed upon and removed D-Trivial Nice and easy! A great choice to get started with Bevy labels Jun 10, 2024
jgayfer
jgayfer approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@jgayfer jgayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 10, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 10, 2024
@alice-i-cecile
Copy link
Member

Merging relatively rapidly; merge conflicts on code reorganizations are miserable.

Merged via the queue into bevyengine:main with commit 2ccdae7 Jun 10, 2024
28 checks passed
@BobG1983 BobG1983 deleted the split_event_module branch June 10, 2024 22:00
@alice-i-cecile alice-i-cecile mentioned this pull request Jun 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@jgayfer jgayfer jgayfer approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BobG1983 @alice-i-cecile @jgayfer