Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "constrain WorldQuery::init_state argument to ComponentInitial… #13804

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Revert "constrain WorldQuery::init_state argument to ComponentInitial… #13804

merged 1 commit into from
Jun 11, 2024

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Jun 11, 2024 •
edited

…izer (#13442)"

This reverts commit 5cfb063.

alice-i-cecile
alice-i-cecile approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this as a next step.

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 11, 2024
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 11, 2024
@Victoronz
Copy link
Contributor

This should reopen #13358 on merge.
This was initially done to make the trait design consistent, so it is fine to revert for now.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 11, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 11, 2024
Merged via the queue into bevyengine:main with commit 07a8567 Jun 11, 2024
31 checks passed
mockersf pushed a commit that referenced this pull request Jun 11, 2024
@hymm @mockersf
Revert "constrain WorldQuery::init_state argument to ComponentInitial… (
cdd1f71 
#13804)

…izer (#13442)"

This reverts commit 5cfb063.

- This PR broke bevy-trait-query, which needs to be able to write a
resource in init_state. See #13798 for more details.
- Note this doesn't fix everything as transmutes for bevy-trait-query
will still be broken,. But the current usage in that crate is UB, so we
need to find another solution.
BD103 added a commit to BD103/bevy-website that referenced this pull request Jun 19, 2024
@BD103
feat: remove 13442 migration
767da99 
This change was reverted because it broke `bevy-trait-query`. See bevyengine/bevy#13804 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Victoronz Victoronz Victoronz approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hymm @Victoronz @alice-i-cecile