Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_plugin_added::<Self>() being true during build #13817

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix is_plugin_added::<Self>() being true during build #13817

merged 4 commits into from
Jun 14, 2024

Conversation

kristoff3r
Copy link
Contributor

Objective

Fixes #13815

Solution

Move insertion of the plugin name to after build is called.

Testing

I added a regression test

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-App Bevy apps and plugins labels Jun 11, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 11, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jun 11, 2024
alice-i-cecile
alice-i-cecile approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this behavioral change, and the code is clearer too. I'd like to change the test name (I find the links more useful in the comments than the name) but that's just a nit.

@kristoff3r @alice-i-cecile
Update crates/bevy_app/src/app.rs
12906cc 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@BD103
Copy link
Member

BD103 commented Jun 13, 2024

Should this be considered a breaking change?

@alice-i-cecile
Copy link
Member

IMO no: this restores us to 0.13 behavior.

@mockersf mockersf enabled auto-merge June 14, 2024 19:06
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 14, 2024
@mockersf mockersf added this pull request to the merge queue Jun 14, 2024
Merged via the queue into bevyengine:main with commit 1395e36 Jun 14, 2024
28 checks passed
mockersf added a commit that referenced this pull request Jun 14, 2024
@kristoff3r @alice-i-cecile @mockersf
Fix is_plugin_added::<Self>() being true during build (#13817)
cc4681f 
# Objective

Fixes #13815 

## Solution

Move insertion of the plugin name to after build is called.

## Testing

I added a regression test

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: François Mockers <mockersf@gmail.com>
Co-authored-by: François Mockers <francois.mockers@vleue.com>
@SenneDeVocht SenneDeVocht mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

is_plugin_added is always true for Self
4 participants
@kristoff3r @BD103 @alice-i-cecile @mockersf