Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight dependency on shader files in examples #13824

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Jun 12, 2024

The examples won't work when copy-pasted to another project, without also copying their shader files. This change adds constants at the top of the files to bring attention to the dependencies.

Follow up to #13624

Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what we want, we might also want to add a small CI check to ensure all shader/asset paths are defined in constants (in a follow-up).

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jun 12, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 12, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 12, 2024
@alice-i-cecile
Copy link
Member

Thanks for tackling this: I know these tasks can be really tedious.

Merged via the queue into bevyengine:main with commit 435d9bc Jun 12, 2024
31 checks passed
@kornelski kornelski deleted the shader-examples branch June 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants