-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mac OS tracy info to profiling docs #13826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though this should be moved to the Contributor's Guide once that is more finished. :)
@mweatherley I'll merge this once the merge conflicts and linting errors are resolved. |
This is the markdownlint error message for reference, copied from CI:
|
Yeah, the issue is just that it has to be redone completely, since the current formatting can't actually be done in markdown without inline HTML. I can try rewriting the section in a way that incorporates it, I guess. |
Co-authored-by: Jerome Humbert <djeedai@gmail.com>
Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
Explanation
I got kind of lost on this earlier (the Tracy docs are not very helpful) and required some assistance, so I thought it might be helpful to add this somewhere in the profiling docs. The way it's presently inserted is kind of awkward, but I don't know enough about the other operating systems to make similar sections for them, which I think would be helpful, since it's going to be different on each one.