Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made some things in bevy_render Debug. #13830

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Made some things in bevy_render Debug. #13830

merged 1 commit into from
Jun 17, 2024

Conversation

mintlu8
Copy link
Contributor

@mintlu8 mintlu8 commented Jun 13, 2024

Objective

Some items in bevy_render do not implement Debug.

Solution

Made them derive Debug.

alice-i-cecile
alice-i-cecile approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to keep this in draft?

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 13, 2024
@mintlu8 mintlu8 marked this pull request as ready for review June 13, 2024 20:47
@mintlu8
Copy link
Contributor Author

mintlu8 commented Jun 13, 2024

Any reason to keep this in draft?

Oops forgot this existed :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 17, 2024
Merged via the queue into bevyengine:main with commit c75610e Jun 17, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mintlu8 @alice-i-cecile