Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text position: use size instead of bounds #13858

Merged
merged 3 commits into from
Jun 16, 2024
Merged

text position: use size instead of bounds #13858

merged 3 commits into from
Jun 16, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • bounds are infinite
  • use computed size instead, that already should be using the available bounds

@mockersf mockersf added this to the 0.14 milestone Jun 15, 2024
@mockersf mockersf requested a review from robtfm June 15, 2024 09:01
@robtfm
Copy link
Contributor

robtfm commented Jun 15, 2024

I think this will revert to the original behaviour in the test code I posted in the pr that caused the problem ..?

@robtfm
Copy link
Contributor

robtfm commented Jun 15, 2024 •
edited
Loading

I guess we can just use the size if !bounds.x.is_finite(). I don’t really understand what alignment should mean with infinite bounds otherwise.

@mockersf
Copy link
Member Author

change it to use the bound when its finite, otherwise the size

@janhohenheim janhohenheim added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Text Rendering and layout for characters D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jun 15, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 16, 2024
Merged via the queue into bevyengine:main with commit d8f4260 Jun 16, 2024
27 checks passed
mockersf added a commit that referenced this pull request Jun 16, 2024
@mockersf
text position: use size instead of bounds (#13858)
55ee49b 
# Objective

- #13846 introduced a bug where text not bound was not displayed

## Solution

- bounds are infinite
- use computed size instead, that already should be using the available
bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robtfm robtfm robtfm approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mockersf @robtfm @pablo-lua @alice-i-cecile @janhohenheim