Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add labels and ordering for transform propagation and parent update systems in POST_UPDATE stage #1456

Merged
merged 1 commit into from
Feb 17, 2021
Merged

add labels and ordering for transform propagation and parent update systems in POST_UPDATE stage #1456

merged 1 commit into from
Feb 17, 2021

Conversation

mockersf
Copy link
Member

fixes #1450

using system name as label, and setting order for transform propagation to happen after parent updates

@mockersf
Copy link
Member Author

oh just noticed #1438 that does add one label, but no ordering so doesn't fix the issue

@MinerSebas
Copy link
Contributor

There is also #1198 that made them run in different stages.

@alice-i-cecile
Copy link
Member

See also #1423, which should be ready to merge and will change the types of our labels.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it P-High This is particularly urgent, and deserves immediate attention labels Feb 17, 2021
@alice-i-cecile
Copy link
Member

IMO this should be merged ASAP @cart to make the development experience on master usable for plugin writers, and then we can clean up the labels after #1423 is merged.

@alice-i-cecile alice-i-cecile mentioned this pull request Feb 17, 2021
Closed
@cart
Copy link
Member

cart commented Feb 17, 2021

Looks good to me! We can decide if / how we export labels later.

@cart cart merged commit a5d2501 into bevyengine:master Feb 17, 2021
@mockersf mockersf deleted the parent-transform branch April 27, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alien_cake_addict example - game board does not appear
4 participants
@mockersf @MinerSebas @alice-i-cecile @cart