[Merged by Bors] - Small improvement of code quality of Assets::set* methods #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a warning when the return value of ::set isn't used.
alice-i-cecile
added
A-Assets
mockersf
approved these changes
Mar 13, 2021
|
I dig it! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2021
As mentioned in #1609. I'm not sure if this is desirable, but on top of factoring the `set` and `set_untracked` methods I added a warning when the return value of `set` isn't used to mitigate similar issues. I silenced it for the only occurence where it's currently done https://github.com/bevyengine/bevy/blob/68606934e32ab45828c628e1cefd3873273f8708/crates/bevy_asset/src/asset_server.rs#L468
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1609.
I'm not sure if this is desirable, but on top of factoring the
setandset_untrackedmethods I added a warning when the return value ofsetisn't used to mitigate similar issues.I silenced it for the only occurence where it's currently done
bevy/crates/bevy_asset/src/asset_server.rs
Line 468 in 6860693