[Merged by Bors] - Mesh vertex attributes for skinning and animation #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Apr 6, 2021
alice-i-cecile
added
C-Enhancement
lassade
added a commit
to lassade/bevy
that referenced
this pull request
Apr 11, 2021
5 tasks
cart
reviewed
Apr 13, 2021
crates/bevy_render/src/mesh/mesh.rs
Outdated
| @@ -204,16 +208,26 @@ impl From<&Indices> for IndexFormat { | |||
| } | |||
|
|
|||
| // TODO: allow values to be unloaded after been submitting to the GPU to conserve memory | |||
| #[derive(Debug, TypeUuid, Clone)] | |||
| #[derive(Debug, TypeUuid, Clone, Reflect)] | |||
There was a problem hiding this comment.
If Reflect is only being added for your animation system, can we just add it in the animation pr instead? Otherwise this impl seems a bit pointless / I probably wouldn't include it. I think requiring "empty reflect impls" is something thats worth discussing in the animation pr.
cart
force-pushed
the
vert-attrs-for-skinning
branch
from
202ed1d
to
ca0d0a5
Compare
|
Just scoped this down to adding the relevant attribute names. I also removed the Ushort4 addition because we added all of the variants recently (and changed naming conventions to match the new wgpu naming conventions). |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 6, 2021
Required by #1429, - Adds the `Ushort4` vertex attribute for joint indices - `Mesh::ATTRIBUTE_JOINT_WEIGHT` and `Mesh::ATTRIBUTE_JOINT_INDEX` to import vertex attributes related to skinning from GLTF - impl `Default` for `Mesh` a empty triangle mesh is created (needed by reflect) - impl `Reflect` for `Mesh` all attributes are ignored (needed by the animation system)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
Required by bevyengine#1429, - Adds the `Ushort4` vertex attribute for joint indices - `Mesh::ATTRIBUTE_JOINT_WEIGHT` and `Mesh::ATTRIBUTE_JOINT_INDEX` to import vertex attributes related to skinning from GLTF - impl `Default` for `Mesh` a empty triangle mesh is created (needed by reflect) - impl `Reflect` for `Mesh` all attributes are ignored (needed by the animation system)
vabrador
pushed a commit
to vabrador/bevy
that referenced
this pull request
Sep 15, 2021
Required by bevyengine#1429, - Adds the `Ushort4` vertex attribute for joint indices - `Mesh::ATTRIBUTE_JOINT_WEIGHT` and `Mesh::ATTRIBUTE_JOINT_INDEX` to import vertex attributes related to skinning from GLTF - impl `Default` for `Mesh` a empty triangle mesh is created (needed by reflect) - impl `Reflect` for `Mesh` all attributes are ignored (needed by the animation system)
setzer22
pushed a commit
to Cakefish/bevy
that referenced
this pull request
Nov 17, 2021
Required by bevyengine#1429, - Adds the `Ushort4` vertex attribute for joint indices - `Mesh::ATTRIBUTE_JOINT_WEIGHT` and `Mesh::ATTRIBUTE_JOINT_INDEX` to import vertex attributes related to skinning from GLTF - impl `Default` for `Mesh` a empty triangle mesh is created (needed by reflect) - impl `Reflect` for `Mesh` all attributes are ignored (needed by the animation system)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #1429,
Ushort4vertex attribute for joint indicesMesh::ATTRIBUTE_JOINT_WEIGHTandMesh::ATTRIBUTE_JOINT_INDEXto import vertex attributes related to skinning from GLTFDefaultforMesha empty triangle mesh is created (needed by reflect)ReflectforMeshall attributes are ignored (needed by the animation system)