[Merged by Bors] - Asset re-loading while it's being deleted #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Assets
NathanSWard
reviewed
Apr 26, 2021
NathanSWard
reviewed
Apr 26, 2021
NathanSWard
reviewed
Apr 27, 2021
Co-Authored-By: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
|
I believe this PR could be marked as |
|
Looks good to me / behaves as expected in my tests: Despawning a SpriteBundle entity with a texture material:
|
|
This does imply that deeply nested dependency chains will now take longer to free up resources. Ex: something with 30 nested dependencies will be freed over the course of |
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
If that becomes an issue, the number of frames spent can be divided by 2 by marking unused assets in a separate system at the end of the frame, after all handles have been freed |
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
fixes bevyengine#824 fixes bevyengine#1956 * marked asset loading methods as `must_use` * fixed asset re-loading while asset is still loading to work as comment is describing code * introduced a 1 frame delay between unused asset marking and actual asset removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #824
fixes #1956
must_use